Add angr #154
Merged
Add angr #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Awesome ! Thanks ! (Confirm Author is main contributor of Angr) |
Member
|
When dropping Python 2 don't forget to read the practicalities section, which explain how to set python_requires to tell pip not to install angr 8 on Python 2 Feel free to ping up on the PR that does it if you want an extra pair of eyes ! |
Contributor
Author
|
That was a fast merge... Thanks a lot! We will read the practicalities section. |
Member
|
I've made a couple of comments on angr/angr#1210 as well that give you the crux of practicalities. And that's quite a big PR ! Enjoy Python 3 ! |
Member
Well it was pretty simple, and it's always good to have one less thing in the todo list :-) |
Contributor
Author
|
FYI This is the actual issue that tracks our entire Python 3 transition process: angr/angr#1209 With more big PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.