-
Notifications
You must be signed in to change notification settings - Fork 121
Start working on the practicalities section. #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2cf782e
Start working on the practicalities section.
Carreau b5e2324
Expand informations
Carreau c344f31
Expand more sections
Carreau b30b966
Fix some comments
Carreau 3bf0156
More infos
Carreau 958ec43
Some refinments
Carreau 7cf319e
'finish up practicalities'
Carreau b542e01
Take into account most of Thomas comments.
Carreau f9ed6e8
Last changes from Thomas
Carreau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Start working on the practicalities section.
- Loading branch information
commit 2cf782ec1a95bc2934138e20ab5193982a46d620
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| _site/ | ||
| .DS_Store | ||
| .DS_Store | ||
| *.swo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,4 +35,5 @@ colors: | |
|
|
||
| collections: | ||
| - sections | ||
| - practicalities | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| --- | ||
| # As a user | ||
|
|
||
| If you are already a Python 3 user, you should not encounter a lot of | ||
| disruption. Please check that the libraries you use follow best practises not | ||
| to break for other users. | ||
|
|
||
| Make sure you have Pip >= 9.0 | ||
|
|
||
| If you are using a custom local package index, for example if you are working | ||
| at a company, make sure it implement correctly pep-512 and let pip knows about | ||
| the `python_requires` field. | ||
|
|
||
|
|
||
|
|
||
|
|
||
| # Preparing your library | ||
|
|
||
| Things to speak about: | ||
|
|
||
| - Be on recent enough setuptools | ||
| - Add a warning at _runtime_ early on master (before switching to Python 3 | ||
| only) | ||
| - Add an error early at import at runtime with a clear error message, leave the | ||
| early import compatible Python 2 for user to not be welcomed with SyntaxError | ||
|
|
||
|
|
||
|
|
||
| # Mitigations | ||
|
|
||
| - Leave `setup.py` python 2 compatible and fail early. If you detect Python 2 | ||
| raise a clear error message and ask user to make sure they have pip >9.0 (or | ||
| migrate to Python 3). You can (try to) conditionally import pip and check for | ||
| its version but this might not be the same pip. | ||
|
|
||
| - If you control dependant packages, Make sure to include conditional | ||
| dependencies depending on the version of Python. | ||
|
|
||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --- | ||
| --- | ||
| <!DOCTYPE html> | ||
| <html dir="ltr" lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>{{ site.title }}</title> | ||
| <meta name="keywords" content="{{ site.keywords }}"> | ||
| <meta name="description" content="{{ site.description }}"> | ||
| <link rel="stylesheet" href="../combo.css"> | ||
| <link href='https://fonts.googleapis.com/css?family=Raleway:400,300,700' rel='stylesheet' type='text/css'> | ||
| <link rel="stylesheet" href="https://netdna.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/vis/4.16.1/vis.min.css"> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/vis/4.16.1/vis.min.js"></script> | ||
| {% if site.favicon %}<link rel="shortcut icon" href="{{ site.favicon }}" type="image/x-icon">{% endif %} | ||
| {% if site.touch_icon %}<link rel="apple-touch-icon" href="{{ site.touch_icon }}">{% endif %} | ||
| </head> | ||
| <body> | ||
| <div id="main"> | ||
|
|
||
|
|
||
| {% for page in site.practicalities %} | ||
| <div class="section"> | ||
|
|
||
| <div class="container {{ page.style }}"> | ||
| {{ page.content }} | ||
| </div> | ||
| </div> | ||
| {% endfor %} | ||
| </div> | ||
| </body> | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP 512 is the GitHub migration, so I think you may mean another PEP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, sorry. I'll fix that to 503 :-)