Skip to content

Conversation

@flying-sheep
Copy link
Contributor

  • A few syntax errors
  • “ficticious”, not “fiction”
  • Unified version bound representation (neither “x >1”, nor “x >1”, but “x > 1”)
  • Made regex multiline for people to understand it.

@takluyver
Copy link
Member

Thanks @flying-sheep ! I'm going to merge this and see how the ≥ symbols look in the webpage - I may want to revert to >= if they're note noticeable enough.

@takluyver takluyver merged commit 77ff30d into python3statement:master Apr 20, 2017
@takluyver
Copy link
Member

This looks OK to me.

screenshot from 2017-04-20 14-59-42

@flying-sheep flying-sheep deleted the patch-1 branch April 20, 2017 14:03
@flying-sheep
Copy link
Contributor Author

great!

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Apr 20, 2017

maybe you can configure smartypants to do this for you. “>=” in non-code honestly looks like weird ASCII art to me.

/edit: apparently not: https://kramdown.gettalong.org/syntax.html#typographic-symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants