Skip to content

Conversation

GregoryComer
Copy link
Member

Summary

As described in the release manual, update torch pins to 2.9.0 for pytorch and torchaudio, 0.24.0 for torchvision. I've followed the same pattern as #12137 (0.7 changes).

Copy link

pytorch-bot bot commented Sep 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14393

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 8bdebd2 with merge base e0dda90 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

@abhinaykukkadapu abhinaykukkadapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping, let's wait for the build to be fine after the pin update.

@GregoryComer
Copy link
Member Author

Docker build failures look like infra failures, will retry to make sure once the workflow completes.

@psiddh
Copy link
Contributor

psiddh commented Sep 17, 2025

Retry CI failures ?

@GregoryComer
Copy link
Member Author

GregoryComer commented Sep 18, 2025

There's a bunch of cancelled / timed out jobs due to missing docker image. Looking into it.

Edit: Looks like it's because 2 docker image build jobs failed due to what appear to be infra failures. I'm re-running now.

@GregoryComer
Copy link
Member Author

The two docker image builds failed again due to losing communication with the runner.

@GregoryComer
Copy link
Member Author

Trying a larger runner (linux.2xlarge -> linux.4xlarge) for the docker build to see if that resolves it.

@mergennachin
Copy link
Contributor

Fix lintrunner

also, I wonder if test-arm-ootb-linux is legit -- we can land this and ask Arm to fix the jupyter notebook

@mergennachin
Copy link
Contributor

Huy suggested to upgrade to linux.4xlarge.memory

https://fb.workplace.com/groups/4571909969591489/posts/24571217539234103/?comment_id=24571440575878466

@GregoryComer
Copy link
Member Author

Huy suggested to upgrade to linux.4xlarge.memory

https://fb.workplace.com/groups/4571909969591489/posts/24571217539234103/?comment_id=24571440575878466

Sounds good. I've bumped it and am re-running now.

@GregoryComer GregoryComer merged commit 5452e68 into release/1.0 Sep 18, 2025
555 of 561 checks passed
@GregoryComer GregoryComer deleted the release-1-0-torch-pins branch September 18, 2025 19:37
@@ -1 +1 @@
4d4abec80f03cd8fdefe1d9cb3a60d3690cd777e
release/2.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for release branch only, not for recurring job

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For main it comes from here https://github.com/pytorch/executorch/blob/main/install_requirements.py#L39? If so where is the pin in pytorch.txt file used for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants