-
Notifications
You must be signed in to change notification settings - Fork 674
[RELEASE ONLY CHANGES] Update torch pins to 2.9 #14393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14393
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 8bdebd2 with merge base e0dda90 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
6f81196
to
841b3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamping, let's wait for the build to be fine after the pin update.
Docker build failures look like infra failures, will retry to make sure once the workflow completes. |
Retry CI failures ? |
There's a bunch of cancelled / timed out jobs due to missing docker image. Looking into it. Edit: Looks like it's because 2 docker image build jobs failed due to what appear to be infra failures. I'm re-running now. |
The two docker image builds failed again due to losing communication with the runner. |
841b3cf
to
a83922b
Compare
Trying a larger runner (linux.2xlarge -> linux.4xlarge) for the docker build to see if that resolves it. |
Fix lintrunner also, I wonder if test-arm-ootb-linux is legit -- we can land this and ask Arm to fix the jupyter notebook |
Huy suggested to upgrade to |
a83922b
to
fb00b7e
Compare
Sounds good. I've bumped it and am re-running now. |
fb00b7e
to
8bdebd2
Compare
@@ -1 +1 @@ | |||
4d4abec80f03cd8fdefe1d9cb3a60d3690cd777e | |||
release/2.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cccclai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for release branch only, not for recurring job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For main it comes from here https://github.com/pytorch/executorch/blob/main/install_requirements.py#L39? If so where is the pin in pytorch.txt file used for.
Summary
As described in the release manual, update torch pins to 2.9.0 for pytorch and torchaudio, 0.24.0 for torchvision. I've followed the same pattern as #12137 (0.7 changes).