Don't use size on TensorVariable when doing out resize test#120567
Closed
ezyang wants to merge 2 commits intogh/ezyang/2580/basefrom
Closed
Don't use size on TensorVariable when doing out resize test#120567ezyang wants to merge 2 commits intogh/ezyang/2580/basefrom
ezyang wants to merge 2 commits intogh/ezyang/2580/basefrom
Conversation
Fixes #120482 Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120567
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit c4f061f with merge base 36c1cc9 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
Fixes #120482 Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
Skylion007
approved these changes
Feb 24, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
This is probably a good backport candidate for the next 2.2 bugfix. |
Contributor
|
@pytorchbot cherry-pick --onto release/2.2 -c regression --fixes #120511 |
pytorchbot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Fixes #120482 Fixes #120511 Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #120567 Approved by: https://github.com/Skylion007 (cherry picked from commit 0f20cc1)
Collaborator
Cherry picking #120567The cherry pick PR is at #121232 and it is recommended to link a regression cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
atalman
pushed a commit
that referenced
this pull request
Mar 7, 2024
Fixes #120482 Fixes #120511 Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #120567 Approved by: https://github.com/Skylion007 (cherry picked from commit 0f20cc1) Co-authored-by: Edward Z. Yang <ezyang@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #120482
Fixes #120511
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng