RFC-0006: a PyTorch conda distribution #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion with `@malfet` we agreed that, given the progress conda-forge is making and GPU hardware for use in CI being added in the near future, it's better to help out with that effort.
rgommers
force-pushed
the
conda-distribution
branch
from
b5ad23c to
117dde3
Compare
rgommers
commented
Mar 19, 2021
There was a problem hiding this comment.
@malfet and I discussed this proposal. We agreed that, given the progress conda-forge is making and GPU hardware for use in CI being added in the near future, it's better to help out with that effort.
So I'll merge this PR with status Rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aims of this proposal are:
Credits for the initial idea of this "integration tested distribution" go to @jph00. Thanks also to @pearu and @hameerabbasi for feedback on an earlier version, on the conda-forge section in particular.
More details on how the CI for this should work can be added, but that can be done after there's agreement that this proposal is the right direction to go in.
EDIT: up-to-date rendered version at https://github.com/rgommers/rfcs/blob/conda-distribution/RFC-0006-conda-distribution.md