Skip to content

[BugFix]: gym 0.25 with from_pixels=True requires render_mode tp be specified #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmoens wants to merge 6 commits into from
Closed

[BugFix]: gym 0.25 with from_pixels=True requires render_mode tp be specified #277

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63e1822
init
vmoens Jul 17, 2022
2bec190
amend
vmoens Jul 17, 2022
fc87b01
amend
vmoens Jul 17, 2022
6af2b13
amend
vmoens Jul 17, 2022
8ff74eb
fix tests
vmoens Jul 17, 2022
319369e
fix tests
vmoens Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
amend
  • Loading branch information
@vmoens
vmoens committed Jul 17, 2022
commit 2bec19039e4b2ab49b8d494ea917e8ebf021daec
4 changes: 2 additions & 2 deletions torchrl/envs/libs/gym.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ class GymWrapper(GymLikeEnv):
def __init__(self, env=None, **kwargs):
if env is not None:
kwargs["env"] = env
if kwargs.get("from_pixels", False):
kwargs["render_mode"] = "single_rgb_array"
self._seed_calls_reset = None
super().__init__(**kwargs)

Expand Down Expand Up @@ -270,6 +268,8 @@ def _build_env(
from_pixels = kwargs.get("from_pixels", False)
if "from_pixels" in kwargs:
del kwargs["from_pixels"]
kwargs["render_mode"] = "single_rgb_array"

pixels_only = kwargs.get("pixels_only", True)
if "pixels_only" in kwargs:
del kwargs["pixels_only"]
Expand Down