Skip to content

[DeepSeek] Move seqlen from model config to setup_symm_mem#1017

Open
kwen2501 wants to merge 8 commits intosymm_bwdfrom
move_seq
Open

[DeepSeek] Move seqlen from model config to setup_symm_mem#1017
kwen2501 wants to merge 8 commits intosymm_bwdfrom
move_seq

Conversation

@kwen2501
Copy link
Contributor

Just a UI change. The seqlen is mainly used in setting up symm mem. That's why we move it out of model config.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 24, 2025
@kwen2501 kwen2501 requested a review from lessw2020 March 24, 2025 23:20
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
One note - the changes in symm_mem_recipes are assumed but not present here in this PR as a change nor in main? (I had to hand add those to get things to run).

verified changes as well:

Creating model stage 0 of 2
Creating model stage 1 of 2
Creating model stage 0 of 2
Creating model stage 1 of 2
EP rank [0]: Created Symmetric Memory for MoE
EP rank [1]: Created Symmetric Memory for MoE
EP rank [1]: Created Symmetric Memory for MoE
EP rank [0]: Created Symmetric Memory for MoE
NCCL version 2.25.1+cuda12.2
NCCL version 2.25.1+cuda12.2
NCCL version 2.25.1+cuda12.2
<|begin▁of▁sentence|>You are a helpful assistant.

User: What is 2+2?

Assistant: 2 + 2 equals 4.<|end▁of▁sentence|>

@meta-cla
Copy link

meta-cla bot commented Nov 22, 2025

Hi @kwen2501!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants