Conversation
lessw2020
left a comment
There was a problem hiding this comment.
lgtm!
One note - the changes in symm_mem_recipes are assumed but not present here in this PR as a change nor in main? (I had to hand add those to get things to run).
verified changes as well:
Creating model stage 0 of 2
Creating model stage 1 of 2
Creating model stage 0 of 2
Creating model stage 1 of 2
EP rank [0]: Created Symmetric Memory for MoE
EP rank [1]: Created Symmetric Memory for MoE
EP rank [1]: Created Symmetric Memory for MoE
EP rank [0]: Created Symmetric Memory for MoE
NCCL version 2.25.1+cuda12.2
NCCL version 2.25.1+cuda12.2
NCCL version 2.25.1+cuda12.2
<|begin▁of▁sentence|>You are a helpful assistant.
User: What is 2+2?
Assistant: 2 + 2 equals 4.<|end▁of▁sentence|>
|
Hi @kwen2501! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Just a UI change. The seqlen is mainly used in setting up symm mem. That's why we move it out of model config.