Make betas and weight_decay Adam(W) hyperparameters configurable#1282
Merged
tianyu-l merged 1 commit intopytorch:mainfrom Jun 11, 2025
Merged
Make betas and weight_decay Adam(W) hyperparameters configurable#1282tianyu-l merged 1 commit intopytorch:mainfrom
betas and weight_decay Adam(W) hyperparameters configurable#1282tianyu-l merged 1 commit intopytorch:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 13, 2026
…ytorch#1282) This change exposes the `betas` and `weight_decay` hyperparameters for Adam(W) to the user by adding them to the `Optimizer` dataclass. The default behavior will be unchanged since I used the previously hard-coded values as the default.
xrsrke
pushed a commit
to NousResearch/torchtitan
that referenced
this pull request
Feb 25, 2026
…ytorch#1282) This change exposes the `betas` and `weight_decay` hyperparameters for Adam(W) to the user by adding them to the `Optimizer` dataclass. The default behavior will be unchanged since I used the previously hard-coded values as the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes the
betasandweight_decayhyperparameters for Adam(W) to the user by adding them to theOptimizerdataclass.The default behavior will be unchanged since I used the previously hard-coded values as the default.