handle unable to load ft checkpoint#1729
Closed
tushar00jain wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
tushar00jain
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
tushar00jain
force-pushed
the
pr1729
branch
3 times, most recently
from
aa92478 to
2abfb3c
Compare
Summary: - not being able to load ft checkpoint crashes the trainer - avoid loading the ft checkpoint for now to continue training
tushar00jain
force-pushed
the
pr1729
branch
from
2abfb3c to
b031fd4
Compare
fegin
requested changes
Sep 22, 2025
Contributor
fegin
left a comment
fegin
left a comment
There was a problem hiding this comment.
This seems to be very dangerous. Do we know why the checkpoint isn't available? _find_load_step already checks the .metadata. So it seems to me that the checkpoint should exist. Can this be the storage consistency issue? If so TorchTitan shouldn't be responsible for doing such check.
Contributor
Author
|
@fegin titan isn't doing the check but if the underlying layer returns an error e.g. because the checkpoint is corrupt, titan shouldn't crash. the metadata check seems it's only looking for the metadata file but it doesn't check the contents of the file or weather the content is intact. so this change makes reading the actual checkpoint safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: