Skip to content

[RFC] Lift freqs_cis as an input of models #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[RFC] Lift freqs_cis as an input of models #1797

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a42c0c
Update
fegin Oct 4, 2025
d6d06d5
Update
fegin Oct 8, 2025
705eebd
Update
fegin Oct 8, 2025
e9c4cf7
Update
fegin Oct 8, 2025
d60c3d6
Update
fegin Oct 9, 2025
827ba00
Update
fegin Oct 9, 2025
f0dfa69
Update
fegin Oct 9, 2025
b05f40d
Update
fegin Oct 10, 2025
5b813a2
Update
fegin Oct 12, 2025
321fe63
Update
fegin Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 
[ghstack-poisoned]
  • Loading branch information
@fegin
fegin committed Oct 8, 2025
commit d6d06d5548f718e89e68f8f56e9bef2192d7a724
2 changes: 0 additions & 2 deletions torchtitan/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ def forward_backward_step(
else:
self.pp_schedule.step(
*order_sensitive_buffers[0],
attention_masks=attention_masks,
target=targets,
losses=losses,
input_batch=inputs,
Expand All @@ -484,7 +483,6 @@ def forward_backward_step(
inputs,
*order_sensitive_buffers[0],
**extra_inputs,
attention_masks=attention_masks,
)
loss = self.loss_fn(pred, labels)
# need to free pred before bwd to avoid peaking memory
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.