-
Notifications
You must be signed in to change notification settings - Fork 644
[CP] Enable FlexCP for llama3 #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fegin
wants to merge
8
commits into
gh/fegin/54/base
Choose a base branch
from
gh/fegin/54/head
base: gh/fegin/54/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fegin
added a commit
that referenced
this pull request
Dec 11, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: c161349 Pull-Request: #2145
This was referenced Dec 11, 2025
fegin
added a commit
that referenced
this pull request
Dec 11, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: 4bced25 Pull-Request: #2145
fegin
added a commit
that referenced
this pull request
Dec 12, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: cf1e8d6 Pull-Request: #2145
fegin
added a commit
that referenced
this pull request
Dec 12, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: 1143a55 Pull-Request: #2145
tianyu-l
reviewed
Dec 14, 2025
fegin
added a commit
that referenced
this pull request
Dec 15, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0) (oldest at bottom): * #2145 * #2144 * __->__ #2143 1. Accept one "." (meaning the current commit) case to simplify the command line. 2. Ignore the untracked files.
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Dec 15, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: 85c9bff Pull-Request: #2145
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Dec 15, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: e3cfb0c Pull-Request: #2145
fegin
added a commit
that referenced
this pull request
Dec 16, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: fd039d4 Pull-Request: #2145
fegin
added a commit
that referenced
this pull request
Dec 16, 2025
Summary: Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer. Note that this PR requires pytorch/pytorch#170201 ghstack-source-id: eb4903d Pull-Request: #2145
tianyu-l
approved these changes
Dec 16, 2025
| v: torch.Tensor, | ||
| *, | ||
| block_mask: BlockMask, | ||
| score_mod: _score_mod_signature | None = None, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arg not used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Continue the previous PR, this PR enable FlexAttention + CP for llama3. FlexCP will use PTRRLoadBalancer.
Note that this PR requires pytorch/pytorch#170201