Skip to content

[transformers_modeling_backend] Upgrade transformers from 4.57.1 to 5.0.0rc0 #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3outeille wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[transformers_modeling_backend] Upgrade transformers from 4.57.1 to 5.0.0rc0 #2154

Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4f36924
add tooling
3outeille Nov 24, 2025
5a63932
add check checkpoint correctness
3outeille Nov 24, 2025
819ea64
add compare throughput to tooling
3outeille Dec 15, 2025
a54016b
Enhance debug_local.sh to support compile flag
3outeille Dec 15, 2025
409483a
Enhance debug_local.sh to support dynamic flavor selection
3outeille Dec 15, 2025
b7e88ce
modify template to use reservation
3outeille Dec 15, 2025
33f7e57
this doesnt exist in v5 anymore (maybe for encoder tho but not for de…
3outeille Dec 15, 2025
f544b93
Fix padding index handling for DTensor in HFTransformerModel class
3outeille Dec 15, 2025
15e44c3
Enhance grid_search_slurm.sh to support dynamic flavor selection and …
3outeille Dec 15, 2025
f0eb064
Merge branch 'tooling' into move-to-v5
3outeille Dec 15, 2025
769a61a
upgrade to transformers v5
3outeille Dec 15, 2025
b6bad9a
avoid copy using _local_tensor()
3outeille Dec 15, 2025
da21ac8
remove tooling
3outeille Dec 15, 2025
ff0dbb9
linting
3outeille Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions torchtitan/experiments/transformers_modeling_backend/tooling_dev/grid_search_slurm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,27 @@
#!/usr/bin/bash

# create a list of model_name
# Parse command line arguments
COMPILE_FLAG=""
FLAVOR="debugmodel"
while [[ $# -gt 0 ]]; do
case $1 in
--compile)
COMPILE_FLAG="--enable_compile"
shift
;;
--flavor)
FLAVOR="$2"
shift 2
;;
*)
echo "Unknown option: $1"
echo "Usage: $0 [--compile] [--flavor FLAVOR]"
exit 1
;;
esac
done

# create a list of model_name

model_names=(
"meta-llama/Llama-3.2-1B" # ✅
Expand Down Expand Up @@ -30,25 +50,25 @@ model_names=(
for model_name in "${model_names[@]}"; do
rm -rf slurm_results/${model_name}

python test_hf_integration.py create_configs --model_name "$model_name" --out_dir slurm_results --flavor debugmodel
python test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/debugmodel/seed_checkpoint --qos high
while [ ! -f slurm_results/${model_name}/debugmodel/seed_checkpoint/status.txt ] || [ "$(cat slurm_results/${model_name}/debugmodel/seed_checkpoint/status.txt)" != "completed" ]; do
python tooling_dev/test_hf_integration.py create_configs --model_name "$model_name" --out_dir slurm_results --flavor $FLAVOR $COMPILE_FLAG
python tooling_dev/test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/${FLAVOR}/seed_checkpoint --qos high
while [ ! -f slurm_results/${model_name}/${FLAVOR}/seed_checkpoint/status.txt ] || [ "$(cat slurm_results/${model_name}/${FLAVOR}/seed_checkpoint/status.txt)" != "completed" ]; do
echo "Waiting for seed checkpoint from ${model_name} to complete ..."
sleep 1
done
python test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/debugmodel --qos high
python tooling_dev/test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/${FLAVOR} --qos high
echo "================"
done

for model_name in "${moe_model_names[@]}"; do
rm -rf slurm_results/${model_name}

USE_MOE=1 python test_hf_integration.py create_configs --model_name "$model_name" --out_dir slurm_results --flavor debugmodel
USE_MOE=1 python test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/debugmodel/seed_checkpoint --qos high
while [ ! -f slurm_results/${model_name}/debugmodel/seed_checkpoint/status.txt ] || [ "$(cat slurm_results/${model_name}/debugmodel/seed_checkpoint/status.txt)" != "completed" ]; do
USE_MOE=1 python tooling_dev/test_hf_integration.py create_configs --model_name "$model_name" --out_dir slurm_results --flavor $FLAVOR $COMPILE_FLAG
USE_MOE=1 python tooling_dev/test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/${FLAVOR}/seed_checkpoint --qos high
while [ ! -f slurm_results/${model_name}/${FLAVOR}/seed_checkpoint/status.txt ] || [ "$(cat slurm_results/${model_name}/${FLAVOR}/seed_checkpoint/status.txt)" != "completed" ]; do
echo "Waiting for seed checkpoint from ${model_name} to complete ..."
sleep 1
done
USE_MOE=1 python test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/debugmodel --qos high
USE_MOE=1 python tooling_dev/test_hf_integration.py submit_jobs --inp_dir slurm_results/${model_name}/${FLAVOR} --qos high
echo "================"
done
done