[compiler toolkit] Add graph based SAC#2377
Merged
yiming0416 merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
1930e2c to
4899761
Compare
aditvenk
reviewed
Feb 14, 2026
| } | ||
|
|
||
|
|
||
| def apply_sac_pass( |
Contributor
There was a problem hiding this comment.
How will user pass the op_list_to_save from command line?
Can we re-use the existing AC config system to configure apply_sac_pass?
Contributor
Author
There was a problem hiding this comment.
Currently the ops to be saved in SAC are in a hardcoded list for each model.
Not sure if it's a good UX for user to pass from command line though, as the list itself could be pretty long and not cli-friendly
aditvenk
approved these changes
Feb 21, 2026
6daa539 to
9558d43
Compare
641f6c5 to
50e5b7f
Compare
50e5b7f to
e5b4b14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add graph-based SAC as a joint graph pass in alternative to eager-mode AC. Previously eager AC and fullmodel trace don't compose in DSv3 (See #1935). With graph based AC, it's no longer an issue.
Set
--compile.joint_passes apply_sacto turn it onLlama3-8B (TP=2, FSDP=2)
no-AC: memory: 67.19GiB(37.67%) tps: 9,569 tflops: 554.17 mfu: 24.63%
eager SAC: memory: 45.88GiB(25.73%) tps: 8,627 tflops: 499.62 mfu: 22.21%
graph SAC: memory: 44.20GiB(24.78%) tps: 8,007 tflops: 463.74 mfu: 20.61%
DeepSeek-v3 Debug model(TP=2, FSDP=2, EP=2)
no-AC: memory: memory: 12.26GiB(6.88%) tps: 59,927 tflops: 32.54 mfu: 1.45%
eager SAC: doesn't work (due to AC HOP mutation issue #1935)
graph SAC: memory: 11.01GiB(6.17%) tps: 53,939 tflops: 29.29 mfu: 1.30%