Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Router.init_weightsinitializesself.gate.weightviatrunc_normal_but never initializesself.gate.bias. Undertorch.use_deterministic_algorithms(True), PyTorch'sfill_uninitialized_memoryfills the bias with NaN, which poisons all router scores and produces NaN loss from step 1.Also defensively initializes
FeedForwardbiases (not currently triggered sincebias=Falseby default).Root cause
nn.Linearallocates bias withtorch.empty. Normally this contains finite garbage that gets overwritten during training. Withfill_uninitialized_memory=True(enabled by deterministic mode), uninitialized memory is filled with NaN to surface exactly this kind of bug.Fix
Zero-initialize biases in
Router.init_weightsandFeedForward.init_weights.Testing
Verified with gpt_oss debugmodel (
NGPU=1 MODULE=gpt_oss CONFIG=gpt_oss_debugmodel) and--debug.deterministicacross seeds 0, 42, 123, 999 — all produce converging loss where previously every step was NaN.