[DTensor Bugfix] Explicitly specify grad_placements in to_local to ensure necessary all reduce takes place #2532
Open
acisseJZhong wants to merge 4 commits intomainfrom
Open
[DTensor Bugfix] Explicitly specify grad_placements in to_local to ensure necessary all reduce takes place #2532acisseJZhong wants to merge 4 commits intomainfrom
acisseJZhong wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved #2217 by @alpemreacar
Problem:
x.to_local()was called on a multi-dimensional DTensor (e.g., on a(dp, tp)mesh with placements like(Shard(0), Replicate())). The bareto_local()strips all mesh dimensions and loses gradient placement info for the non-DP (TP) dimensions. For aReplicate()RMSNorm weight on the TP mesh, the backward should producePartial()gradients (requiring all-reduce), but this information was lost.Fix:
xThis ensures that in the backward pass, gradients flowing back through
to_local()are properly wrapped as a DTensor withPartial()on the TP mesh dimension, which will trigger the necessary all-reduce across TP ranks.Authored with Claude.