Skip to content

Make CheckpointManager friendlier to custom StorageWriter/StorageReader #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimdi-y wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make CheckpointManager friendlier to custom StorageWriter/StorageReader #789

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f3afed
Make checkpoint manager extendable for other StorageWriters
dimdi-y Jan 10, 2025
d38a017
Add tests
dimdi-y Jan 12, 2025
6fda9a1
Tidy up a little
dimdi-y Jan 12, 2025
dba9dad
fix lint
dimdi-y Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix lint
  • Loading branch information
@dimdi-y
dimdi-y committed Jan 13, 2025
commit dba9dad1873b6497b80fd55012ca9a47f7f71842
2 changes: 1 addition & 1 deletion torchtitan/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def load(self, step: int = -1) -> bool:

def _remove_checkpoint(self, step: int) -> None:
"""Remove a checkpoint for the given step.

Can be overriden for compatibility with custom storage_reader/storage_writer
"""
path = self._create_checkpoint_id(step)
Expand Down