Merge pull request #115 from jliben/fix-spawn-options

fix: spawn options are processed

Author: Quentin Rossetti

.github/workflows/npm-publish-github-packages.yml

@@ -0,0 +1,36 @@
+# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
+# For more information see: https://help.github.com/actions/language-and-framework-guides/publishing-nodejs-packages
+
+name: Node.js Package
+
+on:
+  release:
+    types: [created]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: 16
+      - run: npm ci
+      - run: npm test
+
+  publish-gpr:
+    needs: build
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: 16
+          registry-url: https://npm.pkg.github.com/
+      - run: npm ci
+      - run: npm publish
+        env:
+          NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}

package.json

@@ -15,7 +15,7 @@
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/quentinrossetti/node-7z.git"
+    "url": "https://github.com/jliben/node-7z.git"
   },
   "keywords": [
     "node",
@@ -27,7 +27,9 @@
     "wrapper"
   ],
   "author": "Quentin Rossetti <quentin.rossetti@gmail.com>",
-  "contributors": [],
+  "contributors": [
+    {"name": "Jessé LIBEN", "email": "jliben@gmail.com"}
+  ],
   "license": "ISC",
   "bugs": {
     "url": "https://github.com/quentinrossetti/node-7zip/issues"

src/lifecycle.js

@@ -51,6 +51,7 @@ export const createFactory = ({
   seven._dataType = Parser.fetch(options._command, 'dataType')
   seven._matchInfos = Parser.matchInfos
   seven._matchProgress = Parser.matchProgress
+  seven._spawnOptions = options.$spawnOptions
   seven.info = new Map()
   debug('lifecycle: create %O', options)
   return seven

test/unit/lifecycle.spec.js

@@ -45,6 +45,21 @@ describe('Unit: lifecycle.js', function () {
       expect(sevenFake._stage).to.eql(STAGE_HEADERS)
     })
 
+    it('should handle $spawnOptions', function () {
+      const create = Seven.createFactory({
+        Bin: binFromOptionsFake,
+        Flags: flagsFromOptionsFake,
+        Parser: parserFake,
+        Args: argsFromOptionsFake
+      })
+      const sevenFake = create({
+        $spawnOptions: {
+          background: false
+        }
+      })
+      expect(sevenFake._spawnOptions.background).to.eql(false)
+    })
+
     it('should set _isProgressFlag when specified', function () {
       const create = Seven.createFactory({
         Bin: binFromOptionsFake,