Merged
Conversation
jliben
commented
Feb 22, 2022
test/unit/lifecycle.spec.js
Outdated
| expect(sevenFake._stage).to.eql(STAGE_HEADERS) | ||
| }) | ||
|
|
||
| it.only('should handle $spawnOptions', function () { |
Contributor
Author
There was a problem hiding this comment.
oops I forgot to remove the only flag here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this nice lib to compress a pretty big folder, I realized that the child_process is spawned as a background process.
On my (windows) machine, this leads to the 7za child to continue running when I interrupt the node.js program that spawned it.
I think it would make sense to default the
detachedoption of the child_process to false, however, in order to keep background compatibility, I tried to use the documented $spawnOptions, like so:Just realised it was not processed, so I'm submitting this little fix to support it.
Basic unit tests added as well, I could not really figure out how to write more advanced integration tests.