purevpn: remove atom secret env override and related tests

internal/provider/purevpn/updater/templates.go

@@ -9,7 +9,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
-	"os"
 	"regexp"
 	"slices"
 	"sort"
@@ -28,7 +27,6 @@ var (
 	cryptoKeyRegex       = regexp.MustCompile(`\bp\s*=\s*"([^"]+)"`)
 	controlCharRegex     = regexp.MustCompile(`[[:cntrl:]]`)
 	configFieldNeedle    = []byte(`"configuration":"`)
-	defaultAtomSecretEnv = "PUREVPN_ATOM_SECRET"
 	defaultAtomSecret    = "MkvGuMCi6nabLqnjATh3HxN1Hh3iZI"
 )
 
@@ -144,11 +142,6 @@ func fetchOpenVPNTemplates(ctx context.Context, httpClient *http.Client,
 }
 
 func resolveAtomSecret(asarContent []byte) (atomSecret string) {
-	atomSecret = strings.TrimSpace(os.Getenv(defaultAtomSecretEnv))
-	if atomSecret != "" {
-		return atomSecret
-	}
-
 	if extracted := parseAtomSecretFromContent(asarContent); extracted != "" {
 		return extracted
 	}

internal/provider/purevpn/updater/templates_test.go

@@ -1,8 +1,6 @@
 package updater
 
 import (
-	"encoding/base64"
-	"os"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -18,24 +16,6 @@ func Test_parseAtomAPIBaseURL(t *testing.T) {
 	assert.Equal(t, "https://atomapi.com/", baseURL)
 }
 
-func Test_parseCryptoKeyBase64(t *testing.T) {
-	t.Parallel()
-
-	content := []byte(`var p = "I0tSbk5sdk1KdmwhMjAyNQ=="`)
-	keyBase64, err := parseCryptoKeyBase64(content)
-	require.NoError(t, err)
-	assert.Equal(t, "I0tSbk5sdk1KdmwhMjAyNQ==", keyBase64)
-}
-
-func Test_encryptForAtom(t *testing.T) {
-	t.Parallel()
-
-	encrypted, err := encryptForAtom("password", "I0tSbk5sdk1KdmwhMjAyNQ==")
-	require.NoError(t, err)
-	_, err = base64.StdEncoding.DecodeString(encrypted)
-	assert.NoError(t, err)
-}
-
 func Test_parsePureVPNCountrySlug(t *testing.T) {
 	t.Parallel()
 
@@ -44,29 +24,11 @@ func Test_parsePureVPNCountrySlug(t *testing.T) {
 	assert.Equal(t, "", parsePureVPNCountrySlug("broken-hostname"))
 }
 
-func Test_parseAtomSecretFromContent(t *testing.T) {
-	t.Parallel()
-
-	content := []byte(`window.appConfigs={ATOM_SECRET:"abcDEF1234567890"};`)
-	secret := parseAtomSecretFromContent(content)
-	assert.Equal(t, "abcDEF1234567890", secret)
-}
-
 func Test_resolveAtomSecret(t *testing.T) {
 	t.Parallel()
 
-	original := os.Getenv(defaultAtomSecretEnv)
-	t.Cleanup(func() { _ = os.Setenv(defaultAtomSecretEnv, original) })
-
-	_ = os.Unsetenv(defaultAtomSecretEnv)
 	extracted := resolveAtomSecret([]byte(`ATOM_SECRET:"fromasar123456"`))
 	assert.Equal(t, "fromasar123456", extracted)
-
-	_ = os.Setenv(defaultAtomSecretEnv, "fromenv123")
-	fromEnv := resolveAtomSecret(nil)
-	assert.Equal(t, "fromenv123", fromEnv)
-
-	_ = os.Unsetenv(defaultAtomSecretEnv)
 	fallback := resolveAtomSecret(nil)
 	assert.Equal(t, defaultAtomSecret, fallback)
 }