Skip to content

[RMBWEB-2780] Support for structured validation results #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 29, 2022
Merged

[RMBWEB-2780] Support for structured validation results #87

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
83cd99a
implement struct validation result
Luncher May 10, 2022
8d68591
fix typo
Luncher May 10, 2022
f466115
restruct normalize raw error
Luncher May 12, 2022
db9f109
update state comment
Luncher May 12, 2022
227f425
fix typo
Luncher May 13, 2022
d84c44a
remove rawError from ValidateResultWithError
Luncher May 13, 2022
90e4499
update test case
Luncher May 13, 2022
78f35e5
fix typo
Luncher May 16, 2022
b2f88ba
update check error condition
Luncher May 16, 2022
e5afe2a
remove debug info
Luncher May 16, 2022
3e45f64
add test case
Luncher May 16, 2022
511d66f
fix throw error test case
Luncher May 20, 2022
b8fb666
restruct error hierarchy
Luncher May 20, 2022
9065ddf
restruct docs and misc
Luncher May 20, 2022
5d56725
fix test case
Luncher May 20, 2022
2c76ca8
update comments
Luncher May 23, 2022
a8cb353
rename _error
Luncher May 23, 2022
031f8a1
fix override state props
Luncher May 23, 2022
ba4b45e
abstract error
Luncher May 23, 2022
dbba8f5
fix infinity error
Luncher May 23, 2022
a5ec69d
fix typo
Luncher May 23, 2022
82e505b
fix typo
Luncher May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove debug info
  • Loading branch information
@Luncher
Luncher committed May 16, 2022
commit e5afe2ac4ba190baf4b0458cd311581f7e7c2e6e
1 change: 0 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export function normalizeError(rawError: ValidationRawError): ValidationError {
export function isErrorObject(err: any): err is ValidationErrorObject {
if (err != null && typeof err === 'object' && 'message' in err) {
Copy link
Collaborator

@nighca nighca May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是最好再加个 typeof err.message === 'string'？

Copy link
Collaborator

@nighca nighca May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. 如果加了 typeof err.message === 'string'，好像 'message' in err 也可以省了

if (!err.message) {
console.log(err)
throw new Error('ValidationErrorObject message property cannot be empty')
Copy link
Collaborator

@nighca nighca May 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在这（isErrorObject）抛错不合理吧..放到 setError 去抛可能会好一点，甚至 normalizeError 也比这里好

}
return true
Expand Down