Skip to content

Features/resume default v2 #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YangSen-qn merged 5 commits into from
Jul 11, 2025

ci: windows-2019 -> windows-2022

76e55b0
Select commit
Loading
Failed to load commit list.
Merged

Features/resume default v2 #463

ci: windows-2019 -> windows-2022
76e55b0
Select commit
Loading
Failed to load commit list.
qiniu-x / pylint completed Jul 7, 2025 in 37s

pylint found 50 issues related to your changes

This is the detailed log.

If you have any questions about this comment, feel free to raise an issue here.

Details

🔍 Check Results Details

The following shows all issues found related to your changes:

examples/upload_callback.py:1: Missing module docstring (missing-module-docstring)
examples/upload_callback.py:6: Constant name "access_key" doesn't conform to UPPER_CASE naming style (invalid-name)
examples/upload_callback.py:7: Constant name "secret_key" doesn't conform to UPPER_CASE naming style (invalid-name)
examples/upload_callback.py:23: Constant name "localfile" doesn't conform to UPPER_CASE naming style (invalid-name)
tests/cases/test_services/test_storage/test_uploader.py:158: Missing function or method docstring (missing-function-docstring)
tests/cases/test_services/test_storage/test_uploader.py:158: Too many arguments (7/5) (too-many-arguments)
tests/cases/test_services/test_storage/test_uploader.py:163: Redefining name 'commonly_options' from outer scope (line 49) (redefined-outer-name)
tests/cases/test_services/test_storage/test_uploader.py:165: Redefining name 'get_key' from outer scope (line 84) (redefined-outer-name)
tests/cases/test_services/test_storage/test_uploader.py:184: Missing function or method docstring (missing-function-docstring)
tests/cases/test_services/test_storage/test_uploader.py:184: Redefining name 'get_key' from outer scope (line 84) (redefined-outer-name)
tests/cases/test_services/test_storage/test_uploader.py:453: Missing function or method docstring (missing-function-docstring)
tests/cases/test_services/test_storage/test_uploader.py:453: Too many arguments (6/5) (too-many-arguments)
tests/cases/test_services/test_storage/test_uploader.py:453: Redefining name 'commonly_options' from outer scope (line 49) (redefined-outer-name)
tests/cases/test_services/test_storage/test_uploader.py:453: Redefining name 'get_key' from outer scope (line 84) (redefined-outer-name)
tests/cases/test_services/test_storage/test_uploader.py:457: Unused variable 'info' (unused-variable)
tests/cases/test_services/test_storage/test_uploader.py:473: Missing function or method docstring (missing-function-docstring)
tests/cases/test_services/test_storage/test_uploader.py:473: Too many arguments (6/5) (too-many-arguments)
tests/cases/test_services/test_storage/test_uploader.py:473: Redefining name 'commonly_options' from outer scope (line 49) (redefined-outer-name)
tests/cases/test_services/test_storage/test_uploader.py:473: Redefining name 'get_key' from outer scope (line 84) (redefined-outer-name)
qiniu/services/storage/uploader.py:16: Too many arguments (12/5) (too-many-arguments)
qiniu/services/storage/uploader.py:22: Unused argument 'check_crc' (unused-argument)
qiniu/services/storage/uploader.py:25: Unused argument 'hostscache_dir' (unused-argument)
qiniu/services/storage/uploader.py:70: Too many arguments (16/5) (too-many-arguments)
qiniu/services/storage/uploader.py:70: Too many local variables (16/15) (too-many-locals)
qiniu/services/storage/uploader.py:73: Unused argument 'hostscache_dir' (unused-argument)
qiniu/services/storage/uploader.py:109: Too many arguments (15/5) (too-many-arguments)
qiniu/services/storage/uploader.py:147: Too many arguments (15/5) (too-many-arguments)
qiniu/services/storage/uploader.py:147: Too many local variables (22/15) (too-many-locals)
qiniu/services/storage/uploader.py:149: Unused argument 'check_crc' (unused-argument)
qiniu/services/storage/uploader.py:202: Too many arguments (13/5) (too-many-arguments)
qiniu/services/storage/uploader.py:243: Too many arguments (18/5) (too-many-arguments)
qiniu/services/storage/uploader.py:243: Too many local variables (18/15) (too-many-locals)
qiniu/services/storage/uploader.py:249: Unused argument 'hostscache_dir' (unused-argument)
qiniu/services/storage/uploader.py:310: Too many arguments (17/5) (too-many-arguments)
qiniu/services/storage/uploader.py:310: Too many local variables (17/15) (too-many-locals)
qiniu/services/storage/uploader.py:375: Too many arguments (17/5) (too-many-arguments)
qiniu/services/storage/uploader.py:375: Too many local variables (18/15) (too-many-locals)
qiniu/services/storage/uploader.py:13: Unused _Resume imported from qiniu.services.storage.legacy (unused-import)
tests/cases/test_http/conftest.py:9: Missing function or method docstring (missing-function-docstring)
examples/upload.py:5: Unused urlsafe_base64_encode imported from qiniu (unused-import)
examples/upload.py:6: Unused import qiniu.config (unused-import)
examples/upload_with_qvmzone.py:1: Missing module docstring (missing-module-docstring)
examples/upload_with_qvmzone.py:5: Unused import qiniu.config (unused-import)
examples/upload_pfops.py:1: Missing module docstring (missing-module-docstring)
examples/upload_pfops.py:5: Constant name "access_key" doesn't conform to UPPER_CASE naming style (invalid-name)
examples/upload_pfops.py:6: Constant name "secret_key" doesn't conform to UPPER_CASE naming style (invalid-name)
examples/upload_pfops.py:34: Constant name "localfile" doesn't conform to UPPER_CASE naming style (invalid-name)
qiniu/utils.py:1: Missing module docstring (missing-module-docstring)
qiniu/utils.py:271: Missing function or method docstring (missing-function-docstring)
qiniu/utils.py:276: Formatting a regular string which could be an f-string (consider-using-f-string)
examples/upload_with_zone.py:1: Missing module docstring (missing-module-docstring)
qiniu/services/storage/legacy.py:15: Class '_Resume' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
qiniu/services/storage/legacy.py:15: Too many instance attributes (20/7) (too-many-instance-attributes)
qiniu/services/storage/legacy.py:90: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
qiniu/services/storage/legacy.py:109: Unnecessarily calls dunder method __contains__. Use in keyword. (unnecessary-dunder-call)
qiniu/services/storage/legacy.py:110: Unnecessarily calls dunder method __contains__. Use in keyword. (unnecessary-dunder-call)
qiniu/services/storage/legacy.py:111: Unnecessarily calls dunder method __contains__. Use in keyword. (unnecessary-dunder-call)
qiniu/services/storage/legacy.py:183: Attribute 'recovery_index' defined outside __init__ (attribute-defined-outside-init)
qiniu/services/storage/legacy.py:179: Attribute 'expiredAt' defined outside __init__ (attribute-defined-outside-init)
qiniu/services/storage/legacy.py:179: Attribute 'uploadId' defined outside __init__ (attribute-defined-outside-init)

🔄 How to Handle?

  1. Fix the issues above and submit your code again
  2. Or click the Re-run button to run the check again
  3. If you think this is a false positive, please contact your support team

ℹ️ Notes

  • To avoid too many comments, only the top 10 issues will be shown in PR comments
  • For any other issues, feel free to create an issue in reviewbot repository
View more details on qiniu-x