Sourcery refactored master branch #1
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if node: | ||
| queue.append(node.left) | ||
| queue.append(node.right) | ||
| queue.extend((node.left, node.right)) |
There was a problem hiding this comment.
Function Solution.isSymmetric refactored with the following changes:
- Merge consecutive list appends into a single extend (
merge-list-appends-into-extend)
| if token == '+': stack.append(x + y) | ||
| if token == '-': stack.append(x - y) | ||
| if token == '*': stack.append(x * y) | ||
| if token == '/': stack.append(int(x / y)) | ||
| if token == '*': | ||
| stack.append(x * y) | ||
| elif token == '+': | ||
| stack.append(x + y) | ||
| elif token == '-': | ||
| stack.append(x - y) | ||
| elif token == '/': | ||
| stack.append(int(x / y)) |
There was a problem hiding this comment.
Function Solution.evalRPN refactored with the following changes:
- Simplify conditional into switch-like form (
switch)
| for _ in range(index, len(nums2)): | ||
| if(nums2[_]>number): | ||
| return nums2[_] | ||
| return -1 | ||
| return next( | ||
| (nums2[_] for _ in range(index, len(nums2)) if (nums2[_] > number)), -1 | ||
| ) |
There was a problem hiding this comment.
Function Solution.check refactored with the following changes:
- Use the built-in function
nextinstead of a for-loop (use-next)
| def myPow(self, x: float, n: int) -> float: | ||
| if not n: return 1 | ||
| power = self.myPow(x, int(n/2)) | ||
| power = self.myPow(x, n // 2) |
There was a problem hiding this comment.
Function Solution.myPow refactored with the following changes:
- Simplify division expressions (
simplify-division)
| ls = s[left] | ||
| else: | ||
| ls = s[left] + ls + s[right] | ||
| ls = s[left] if left==right else s[left] + ls + s[right] |
There was a problem hiding this comment.
Function Solution.longestPalindrome refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| if(s[i]=='('): | ||
| if (s[i]=='('): | ||
| stack.append(i) | ||
| else: | ||
| stack.pop() | ||
| if(len(stack)==0): | ||
| if not stack: |
There was a problem hiding this comment.
Function Solution.longestValidParentheses refactored with the following changes:
- Simplify sequence length comparison (
simplify-len-comparison)
| """ | ||
| lenz = len(nums) | ||
| k = k % lenz | ||
| k %= lenz |
There was a problem hiding this comment.
Function Solution.rotate refactored with the following changes:
- Replace assignment with augmented assignment (
aug-assign)
| # if left half is sorted | ||
|
|
||
| # if left half is sorted | ||
| if nums[low]<=nums[mid]: | ||
| if nums[low]<=target<nums[mid]: | ||
| high = mid-1 | ||
| else: | ||
| low = mid+1 | ||
|
|
||
| # if right half is sorted | ||
|
|
||
| elif nums[mid]<target<=nums[high]: | ||
| low = mid+1 | ||
| else: | ||
| if nums[mid]<target<=nums[high]: | ||
| low = mid+1 | ||
| else: | ||
| high = mid-1 | ||
| high = mid-1 |
There was a problem hiding this comment.
Function Solution.search refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
This removes the following comments ( why? ):
# if right half is sorted
| d = dict() | ||
| for i in range(len(nums)) : | ||
| if nums[i] not in d : | ||
| d[nums[i]] = 1 | ||
| d = {} | ||
| for num in nums: | ||
| if num not in d: | ||
| d[num] = 1 | ||
| else: | ||
| d[nums[i]] += 1 | ||
| d[num] += 1 |
There was a problem hiding this comment.
Function singleNumber refactored with the following changes:
- Replace
dict()with{}(dict-literal) - Replace index in for loop with direct reference (
for-index-replacement)
| dp = [[False]*(n+1) for i in range(m+1)] | ||
|
|
||
| dp = [[False]*(n+1) for _ in range(m+1)] |
There was a problem hiding this comment.
Function Solution.isMatch refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore) - Replace multiple comparisons of same variable with
inoperator (merge-comparisons)
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!