Skip to content

Fixes usage of Tab Key in QWinWidget #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes usage of Tab Key in QWinWidget #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixes usage of Tab Key in QWinWidget 
Tab Key does not work in QWinWidget in some situations
This commit fixes the problem using the code suggested by Andrew
Garrison in the following StackOverflow question:

http://stackoverflow.com/questions/1066183/qwinwidget-inside-mfc-dialog-not-repainting-or-responding-to-tab-arrow-keys
  • Loading branch information
@lukhase
lukhase committed Jan 26, 2015
commit c3716073373a7d0d116f4dd0cb1e7e696e846ec3
12 changes: 8 additions & 4 deletions qtwinmigrate/src/qwinwidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@ void QWinWidget::init()
if (hParent) {
// make the widget window style be WS_CHILD so SetParent will work
QT_WA({
SetWindowLong((HWND)winId(), GWL_STYLE, WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS);
SetWindowLong((HWND) winId(), GWL_STYLE, WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS | WS_TABSTOP);
}, {
SetWindowLongA((HWND)winId(), GWL_STYLE, WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS);
SetWindowLongA((HWND) winId(), GWL_STYLE, WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS | WS_TABSTOP);
})
#if QT_VERSION >= 0x050000
QWindow *window = windowHandle();
Expand Down Expand Up @@ -251,9 +251,9 @@ void QWinWidget::resetFocus()
/*! \reimp
*/
#if QT_VERSION >= 0x050000
bool QWinWidget::nativeEvent(const QByteArray &, void *message, long *)
bool QWinWidget::nativeEvent(const QByteArray &, void *message, long *result)
#else
bool QWinWidget::winEvent(MSG *msg, long *)
bool QWinWidget::winEvent(MSG *msg, long *result)
#endif
{
#if QT_VERSION >= 0x050000
Expand All @@ -270,6 +270,10 @@ bool QWinWidget::winEvent(MSG *msg, long *)
QFocusEvent e(QEvent::FocusIn, reason);
QApplication::sendEvent(this, &e);
}
else if (msg->message == WM_GETDLGCODE) {
*result = DLGC_WANTARROWS | DLGC_WANTTAB;
return true;
}

return false;
}
Expand Down