Added support systemd for qt-service #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangLin
suggested changes
Jul 9, 2021
EndrII
commented
Jul 9, 2021
KangLin
suggested changes
Jul 9, 2021
EndrII
commented
Jul 9, 2021
KangLin
suggested changes
Jul 9, 2021
| QString QtServiceController::serviceDescription() const | ||
| { | ||
| QSettings settings(QSettings::SystemScope, "QtSoftware"); | ||
| auto &settings = getSettings(serviceName()); |
| } | ||
| } | ||
|
|
||
| static QSettings& getSettings(const QString& serviceName) |
|
|
||
| if (isSystemD() && !isServiceInited) | ||
| { | ||
| QSettings::setPath(QSettings::NativeFormat, |
There was a problem hiding this comment.
There are not setPah. It is need caller set. Please see the help of QSettings::setPath.
Two solutions:
- The caller is call QSettings::setPath (The old way)
- Call QSettings::setPath in Constructor
| QtServiceController::StartupType QtServiceController::startupType() const | ||
| { | ||
| QSettings settings(QSettings::SystemScope, "QtSoftware"); | ||
| auto &settings = getSettings(serviceName()); |
| QString QtServiceController::serviceFilePath() const | ||
| { | ||
| QSettings settings(QSettings::SystemScope, "QtSoftware"); | ||
| auto &settings = getSettings(serviceName()); |
|
|
||
| bool QtServiceController::uninstallUpStart() | ||
| { | ||
| auto &settings = getSettings(serviceName()); |
There was a problem hiding this comment.
There are not modify. use QSettings settings(QSettings::SystemScope, "QtSoftware");
| return QFileInfo::exists(systemDPath() + serviceName() + ".service"); | ||
| } | ||
|
|
||
| auto &settings = getSettings(serviceName()); |
There was a problem hiding this comment.
There are not modify. use QSettings settings(QSettings::SystemScope, "QtSoftware");
|
|
||
| QtServiceSysPrivate::QtServiceSysPrivate() | ||
| : QtUnixServerSocket(), ident(0), serviceFlags(0) | ||
| : QtUnixServerSocket(), ident(nullptr), serviceFlags(nullptr) |
| Q_UNUSED(password) | ||
| QSettings settings(QSettings::SystemScope, "QtSoftware"); | ||
|
|
||
| auto &settings = getSettings(controller.serviceName()); |
|
This is not actual anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current qt-service do not working with systemd system, this is PR fix this problem.
I also added the ability to manually set the path to the executable file of the service, since sometimes a service needs a shell that configures its environment.