Skip to content

Snapshot handling improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Snapshot handling improvements #2

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2182e15
Snapshot handling improvements
sklarsa Jun 20, 2023
221a27f
add 2 more webhook acceptance tests
sklarsa Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add 2 more webhook acceptance tests
  • Loading branch information
@sklarsa
sklarsa committed Jun 20, 2023
commit 221a27f4d8fb47f2aeb163cd016dd6da3655f076
14 changes: 14 additions & 0 deletions api/v1beta1/questdbsnapshot_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,25 @@ var _ = Describe("QuestDBSnapshot Webhook", func() {
Expect(k8sClient.Update(ctx, snap)).ToNot(Succeed())
})

It("should reject nil-to-value changes to volume snapshot class names", func() {
snap.Spec.VolumeSnapshotClassName = nil
Expect(k8sClient.Create(ctx, snap)).To(Succeed())
snap.Spec.VolumeSnapshotClassName = pointer.String("foo")
Expect(k8sClient.Update(ctx, snap)).ToNot(Succeed())
})

It("should reject updates to backoff limit", func() {
Expect(k8sClient.Create(ctx, snap)).To(Succeed())
snap.Spec.JobBackoffLimit = 500
Expect(k8sClient.Update(ctx, snap)).ToNot(Succeed())
})

It("should accept updates if nothing has changed and volume snapshot class name is nil", func() {
snap.Spec.VolumeSnapshotClassName = nil
Expect(k8sClient.Create(ctx, snap)).To(Succeed())
Expect(k8sClient.Update(ctx, snap)).To(Succeed())
})

})

})