fix webhook

api/v1beta1/questdb_webhook.go

@@ -47,7 +47,9 @@ var _ webhook.Defaulter = &QuestDB{}
 func (r *QuestDB) Default() {
 	questdblog.Info("default", "name", r.Name)
 
-	// TODO(user): fill in your defaulting logic.
+	if r.Spec.ImagePullPolicy == v1.PullPolicy("") {
+		r.Spec.ImagePullPolicy = v1.PullIfNotPresent
+	}
 }
 
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
@@ -108,10 +110,6 @@ func (r *QuestDB) ValidateCreate() error {
 		return err
 	}
 
-	if r.Spec.ImagePullPolicy == v1.PullPolicy("") {
-		r.Spec.ImagePullPolicy = v1.PullIfNotPresent
-	}
-
 	return nil
 }
 
@@ -157,6 +155,10 @@ func (r *QuestDB) ValidateUpdate(old runtime.Object) error {
 		return errors.New("cannot change storage class name")
 	}
 
+	if r.Spec.ImagePullPolicy == "" {
+		return errors.New("image pull policy cannot be empty")
+	}
+
 	return nil
 }
 

api/v1beta1/questdb_webhook_test.go

@@ -6,6 +6,7 @@ import (
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/utils/pointer"
@@ -73,6 +74,12 @@ var _ = Describe("QuestDB Webhook", func() {
 			}
 			Expect(k8sClient.Create(ctx, q)).ToNot(Succeed())
 		})
+
+		It("should handle an empty image pull policy", func() {
+			q.Spec.ImagePullPolicy = ""
+			Expect(k8sClient.Create(ctx, q)).To(Succeed())
+			Expect(q.Spec.ImagePullPolicy).To(Equal(v1.PullIfNotPresent))
+		})
 	})
 
 	Context("When validating QuestDB Updates", func() {
@@ -136,6 +143,7 @@ var _ = Describe("QuestDB Webhook", func() {
 			q.Spec.Volume.SnapshotName = "foo"
 			Expect(k8sClient.Update(ctx, q)).ToNot(Succeed())
 		})
+
 	})
 
 })

internal/controller/questdb_controller_test.go

@@ -239,14 +239,14 @@ var _ = Describe("QuestDB Controller", func() {
 			By("Changing the image pull policy")
 			Eventually(func(g Gomega) {
 				g.Expect(k8sClient.Get(ctx, client.ObjectKeyFromObject(q), q)).To(Succeed())
-				q.Spec.ImagePullPolicy = "Always"
+				q.Spec.ImagePullPolicy = v1.PullAlways
 				g.Expect(k8sClient.Update(ctx, q)).To(Succeed())
 			}, timeout, interval).Should(Succeed())
 
 			By("Verifying the statefulset has been updated")
 			Eventually(func(g Gomega) {
 				g.Expect(k8sClient.Get(ctx, client.ObjectKey{Name: q.Name, Namespace: q.Namespace}, sts)).To(Succeed())
-				g.Expect(sts.Spec.Template.Spec.Containers[0].ImagePullPolicy).To(Equal("Always"))
+				g.Expect(sts.Spec.Template.Spec.Containers[0].ImagePullPolicy).To(Equal(v1.PullAlways))
 			}, timeout, interval).Should(Succeed())
 		})
 	})