fix bug causing compose activity to finish() when it wasn't supposed to#344
Merged
octoshrimpy merged 1 commit intoquik-sms:masterfrom Mar 12, 2025
gavine99:kicked-to-inbox-on-send-320-haserror-sendasgroup-fix
Merged
fix bug causing compose activity to finish() when it wasn't supposed to#344octoshrimpy merged 1 commit intoquik-sms:masterfrom gavine99:kicked-to-inbox-on-send-320-haserror-sendasgroup-fix
octoshrimpy merged 1 commit intoquik-sms:masterfrom
gavine99:kicked-to-inbox-on-send-320-haserror-sendasgroup-fix
Conversation
…activity) when sending from a new convo as group. also fix associated bug that was sending sms to individual recipients in 'send as group mode' when send as group pref was saved as true
This was referenced Mar 12, 2025
Contributor
Author
|
issue #111 may also be fixed by this pr for similar reason stated above for 335 and 117 |
gavine99
deleted the
kicked-to-inbox-on-send-320-haserror-sendasgroup-fix
branch
This was referenced Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix setting haserror (which is a bit misused to finish() the compose activity) when sending from a new convo as group.
also fix associated bug that was sending sms to individual recipients in 'send as group mode' when send as group pref was saved as true.
possibly closes #320
possibly closes #338
this pr may also fix #335 and #117 because some single-recipient messages may previously have been wrongly sent using the 'send as group' code path which does not necessarily match messages to existing conversations.