Moved draft indicator to text snippet#458
Merged
octoshrimpy merged 2 commits intoquik-sms:masterfrom May 20, 2025
Merged
Conversation
Inhishonor
reviewed
May 18, 2025
Collaborator
Inhishonor
left a comment
Inhishonor
left a comment
There was a problem hiding this comment.
Looks great! I think this is a good change, thanks!
Inhishonor
approved these changes
May 18, 2025
Collaborator
|
Thank you both! |
Closed
This was referenced Nov 13, 2025
Merged
Closed
Merged
This was referenced Dec 9, 2025
Closed
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457. Took a page out of Signal's book here and moved the draft indicator to the text snippet preview. This makes the previous groupchat issue irrelevant, but I also believe it's more consistent with how Quik indicates the user's outgoing messages. Currently they're indicated with
You: ...while drafts have no prefix, which make it seem like an incoming message (especially when combined with the previously mentioned bug).This is my first time taking a stab at android development, so would love to hear any feedback! Kotlin is a liiiiitle unfamiliar to me, along with this codebase. Cheers!