Parse and render emoji reactions#533
Conversation
Fixes part of quik-sms#152 To keep this PR simple, I've left out: - when long-pressing on the emoji in a group MMS, a popup should come up listing which contact sent each emoji - notifications (untested) - sending emoji reactions
Inhishonor
left a comment
There was a problem hiding this comment.
Looks good! I haven't tested too extensively yet, so there might be more once I do that.
presentation/src/main/java/com/moez/QKSMS/feature/compose/BubbleUtils.kt
Outdated
Show resolved
Hide resolved
|
The emojis are getting clipped off at the bottom (it's easier to see in light mode). If anyone here's good at android layout, I'd love some help. |
data/src/main/java/com/moez/QKSMS/migration/QkRealmMigration.kt
Outdated
Show resolved
Hide resolved
|
@Inhishonor the regexes should be localizable now. it's in i18next json format, supported by weblate. it's gonna be annoying/not recommended to edit via weblate because of the invisible unicode characters. but at least it'll show us which translations are missing |
use unicode chars, and allow partial jsons
|
maybe we should just use the same regexes as google messages? although i don't think it handles iOS non-english reactions. Will have to check tomorrow. |
Inhishonor
left a comment
There was a problem hiding this comment.
Looks good, just a few formatting errors.
domain/src/main/java/com/moez/QKSMS/repository/EmojiReactionRepository.kt
Outdated
Show resolved
Hide resolved
Inhishonor
left a comment
There was a problem hiding this comment.
For handling newlines in message content.
Co-authored-by: Inhishonor <inhishonor@protonmail.com>
Co-authored-by: Inhishonor <inhishonor@protonmail.com>
Inhishonor
left a comment
There was a problem hiding this comment.
The suggested change prevents placeholder messages from being scanned,
data/src/main/java/com/moez/QKSMS/repository/EmojiReactionRepositoryImpl.kt
Show resolved
Hide resolved
Co-authored-by: Inhishonor <inhishonor@protonmail.com>
data/src/main/java/com/moez/QKSMS/repository/EmojiReactionRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
…sitoryImpl.kt Co-authored-by: Inhishonor <inhishonor@protonmail.com>
Inhishonor
left a comment
There was a problem hiding this comment.
There will probably be things as soon as we merge, but I think it is good. Thanks very much!
Fixes part of #152
TODO:
the thread summary on the main screen still shows the emoji reaction message(not really a problem)To keep this PR simple, I've left out:
notifications (untested)i think notifs are fine, it just shows the reaction message text which is user friendly already (e.g.Bob Smith reacted 🔥 to "this is lit")