Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

Quran frontend v2 #1005

Merged
mmahalwy merged 36 commits into from
Aug 30, 2018
Merged

Quran frontend v2 #1005

mmahalwy merged 36 commits into from
Aug 30, 2018

Conversation

@mmahalwy
Copy link
Contributor

@mmahalwy mmahalwy commented Jul 27, 2018 •
edited
Loading

Title of change

Quran frontend v2

  • Moving to Typescript
  • Removing the connect files and using async bootstrap
  • Creating containers down the tree for Verses, Words, Audioplayer
  • Containing all the translation ids to one file
  • API requests handled by redux-pack instead of clientMiddleware
  • Breaking down and separating reducers doing more than they should
  • Removing ApiClient
  • Routes handled by react-router on server and client
  • Figuring out what to do with normalizr
  • Navbars handled by react-router on server and client
  • Chapter navbar is a container and dispatches actions
  • Audioplayer is a container not dispatching all changes to redux
  • Write tests
  • Write stories

Checklist

  • Unit tests written
  • Manually tested
  • Prettier & ESLint were run
  • New dependencies are included in package-lock.json

Screenshot

insert screenshot if needed

This was referenced Jul 27, 2018
Open
Closed
@ahmedre
Copy link
Contributor

ahmedre commented Aug 10, 2018

Deployed to: http://staging.quran.com:32854

@ahmedre
Copy link
Contributor

ahmedre commented Aug 10, 2018

Deployed to: http://staging.quran.com:32855

@naveed-ahmad
Copy link
Contributor

naveed-ahmad commented Aug 10, 2018

rebuild

@ahmedre
Copy link
Contributor

ahmedre commented Aug 10, 2018

Deployed to: http://staging.quran.com:32856

@mmahalwy
Copy link
Contributor Author

mmahalwy commented Aug 13, 2018

@naveed-ahmad it builds!!! WOOWW!

@ahmedre
Copy link
Contributor

ahmedre commented Aug 13, 2018

Deployed to: http://staging.quran.com:32859

@thabti thabti mentioned this pull request Aug 29, 2018
Closed
3 tasks
@ahmedre
Copy link
Contributor

ahmedre commented Aug 29, 2018

Deployed to: http://staging.quran.com:32861

@ahmedre
Copy link
Contributor

ahmedre commented Aug 29, 2018

Deployed to: http://staging.quran.com:32862

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32867

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32868

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32869

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32870

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32871

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32872

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32873

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32874

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32875

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32876

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32877

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32878

@ahmedre
Copy link
Contributor

ahmedre commented Aug 30, 2018

Deployed to: http://staging.quran.com:32879

@mmahalwy mmahalwy merged commit e65c4fc into master Aug 30, 2018
@mmahalwy mmahalwy deleted the me--quran-frontend-v2 branch August 30, 2018 17:46
@naveed-ahmad
Copy link
Contributor

naveed-ahmad commented Aug 30, 2018

Been waiting for this for so long. Thanks <3

@mmahalwy
Copy link
Contributor Author

mmahalwy commented Aug 30, 2018

@naveed-ahmad thank you! Finally finished! Although there are a few things I forgot, but created an issue for it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmahalwy @ahmedre @naveed-ahmad