Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

functional tests #401

Merged
mmahalwy merged 8 commits into from
Jul 25, 2016
Merged

functional tests #401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2652302
:triangular_ruler: functional tests
thabti Jul 13, 2016
6f1fd91
[test] local and ci functions
thabti Jul 13, 2016
12e97c9
e-2-e js functional tests
thabti Jul 23, 2016
6bf3b17
remove wait
thabti Jul 24, 2016
8a1f2d1
merge upstream
thabti Jul 24, 2016
6c9ff34
little clean up
thabti Jul 24, 2016
38e9a8f
remove spacing
thabti Jul 24, 2016
10708fe
removing empty lines and refactoring
thabti Jul 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
e-2-e js functional tests
  • Loading branch information
@thabti
thabti committed Jul 24, 2016
commit 12e97c93dd61375bf01cbfe73c826fbb534bc625
1 change: 0 additions & 1 deletion tests/functional/pageobjects/BasePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ module.exports = class BasePage {
};
}


wait(time = 200) {
Copy link
Contributor

@mmahalwy mmahalwy Jul 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more async await?

Copy link
Contributor Author

@thabti thabti Jul 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah apparently latest version of webdriverio handles all the functions in a sync way.


Copy link
Contributor

@mmahalwy mmahalwy Jul 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

browser.pause(time);
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/pageobjects/HomePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default class HomePage extends BasePage {

}

clickOntheSurahByName(number) {
clickOntheSurahByNumber(number) {
const surahs = browser.elements('.row .col-xs-7 span');
const surahID = surahs.value[number].ELEMENT;
browser.elementIdClick(surahID);
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/specs/HomePageTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('Home Page', () => {

it('Should click a surah from the list of surahs and land on the surah page', () => {
homePage.goHome();
const url = homePage.clickOntheSurahByName(1);
const url = homePage.clickOntheSurahByNumber(1);
expect(url).to.contain('/1');

});
Expand Down