feature/scss linting #403
feature/scss linting #403
Conversation
…uran.com-frontend into feature/SCSSLinting
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
there are 100s of rules are available.
I will add them in separate commit with fixes around.
|
Deployed to: http://staging.quran.com:32822 |
package.json
Outdated
| "test:ci:lint": "eslint ./src/**/*.js", | ||
| "test:dev:lint": "eslint ./src/scripts/**/*.js", | ||
| "test:ci:stylelint": "stylelint './src/**/*.scss' --config webpack/.stylelintrc", | ||
| "test:dev:stylelint": "stylelint './src/**/*.scss' --config webpack/.stylelintrc", |
There was a problem hiding this comment.
what is the difference between dev and ci ?
There was a problem hiding this comment.
Good question 👍
@mmahalwy i added "ci" and "dev" entries based on existing ""test:dev:lint" & "test:ci:lint". do we really need both separately?
There was a problem hiding this comment.
for somethings it makes sense but in this case they're similar; Just have test:stylelint.
There was a problem hiding this comment.
Fixed. Thanks :)
…uran.com-frontend into feature/SCSSLinting
…uran.com-frontend into feature/SCSSLinting
|
Deployed to: http://staging.quran.com:32823 |
|
Can you squash your commits and rebase from master? Awesome PR bro. |
|
@sabeurthabti i tried but messed things locally, so better to move :-) |
|
went ahead and merged this - @mmahalwy check and see if there are any changes you want retroactively made |
3 participants
No description provided.