Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixes 438
  • Loading branch information
mmahalwy committed Aug 13, 2016
commit a8f91e1a68115b1fc99f1781f3af13a1d5669173
6 changes: 6 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
"plugins": [
"typecheck"
]
},
"production": {
"plugins": [
"transform-react-inline-elements",
"transform-react-constant-elements"
]
}
}
}
13 changes: 6 additions & 7 deletions start.js → bin/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ require('app-module-path').addPath(__dirname);
require('app-module-path').addPath('./src');

var fs = require('fs');
var path = require('path');
var webpackIsomorphicTools = require('webpack-isomorphic-tools');
var babelrc = fs.readFileSync('./.babelrc');
var rootDir = path.resolve(__dirname, '..');
var config;

try {
Expand All @@ -30,12 +33,8 @@ if (__DEVELOPMENT__) {
}
}

var webpackIsomorphicTools = require('webpack-isomorphic-tools');
// this must be equal to your Webpack configuration "context" parameter
var rootPath = require('path').resolve(__dirname, './')

global.webpack_isomorphic_tools = new webpackIsomorphicTools(require('./webpack/isomorphic-tools-configuration'))
global.webpack_isomorphic_tools = new webpackIsomorphicTools(require('../webpack/isomorphic-tools-configuration'))
.development(process.env.NODE_ENV === 'development')
.server(rootPath, function() {
require('./server.js')();
.server(rootDir, function() {
require('../src/server.js')();
});
18 changes: 18 additions & 0 deletions bin/server.prod.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
require('dotenv').load();
require('app-module-path').addPath(__dirname);
require('app-module-path').addPath('./src');

var path = require('path');
var rootDir = path.resolve(__dirname, '../dist');

global.__CLIENT__ = false;
global.__SERVER__ = true;
global.__DEVELOPMENT__ = process.env.NODE_ENV !== 'production';

var webpackIsomorphicTools = require('webpack-isomorphic-tools');

global.webpack_isomorphic_tools = new webpackIsomorphicTools(require('./webpack/isomorphic-tools-configuration'))
.development(__DEVELOPMENT__)
.server(rootDir, function() {
require('../dist/server.js')();
});
2 changes: 1 addition & 1 deletion docker/supervisord.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
nodaemon=true

[program:pm2]
command=pm2 start /quran/start.js -i 0 --no-daemon
command=pm2 start /quran/bin/server.prod.js -i 0 --no-daemon
directory=/quran
redirect_stderr=true
stdout_logfile=/dev/stdout
Expand Down
11 changes: 8 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@
"posttest:dev:functional": "bash tests/functional/test.sh stop",
"test:dev:lint": "node_modules/eslint/bin/eslint.js ./src/scripts/**/*.js",
"test:stylelint": "node_modules/stylelint/dist/cli.js './src/**/*.scss' --config webpack/.stylelintrc",
"dev": "node webpack/dev-server.js & PORT=8000 node start.js",
"dev": "env NODE_PATH='./src' PORT=8000 UV_THREADPOOL_SIZE=100 node webpack/webpack-dev-server.js & PORT=8000 node ./bin/server.js",
"start": "NODE_PATH=\"./src\" node ./start",
"build": "node ./node_modules/webpack/bin/webpack.js --config webpack/prod.config.js",
"build": "npm run build:client & npm run build:server",
"build:server": "babel src -d dist -D",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to include --copy-files to copy over any none js files.

http://stackoverflow.com/questions/32642685/babel-cli-copy-nonjs-files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-D does that :)

"build:client": "node ./node_modules/webpack/bin/webpack.js --config webpack/prod.config.js",
"validate": "npm ls",
"analyze:build": "env NODE_ENV=production ./node_modules/webpack/bin/webpack.js --json --config webpack/prod.config.js > bundle-stats.json",
"analyze:json": "webpack-bundle-size-analyzer bundle-stats.json"
Expand All @@ -33,7 +35,9 @@
"babel-plugin-add-module-exports": "^0.1.4",
"babel-plugin-system-import-transformer": "^2.0.0",
"babel-plugin-transform-decorators-legacy": "^1.3.4",
"babel-plugin-transform-react-constant-elements": "^6.9.1",
"babel-plugin-transform-react-display-name": "^6.5.0",
"babel-plugin-transform-react-inline-elements": "^6.8.0",
"babel-plugin-transform-runtime": "^6.7.5",
"babel-plugin-typecheck": "^3.8.0",
"babel-polyfill": "^6.7.4",
Expand Down Expand Up @@ -158,7 +162,8 @@
"wdio-mocha-framework": "^0.3.7",
"wdio-spec-reporter": "0.0.3",
"webdriverio": "4.2.1",
"webpack-dev-server": "^1.6.5"
"webpack-dev-server": "^1.6.5",
"webpack-hot-middleware": "^2.12.2"
},
"pre-commit": [
"test:dev:lint",
Expand Down
6 changes: 3 additions & 3 deletions client.js → src/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ import { syncHistoryWithStore } from 'react-router-redux';
import debug from 'debug';

import config from 'config';
import ApiClient from './src/helpers/ApiClient';
import createStore from './src/redux/create';
import routes from './src/routes';
import ApiClient from './helpers/ApiClient';
import createStore from './redux/create';
import routes from './routes';

const client = new ApiClient();
const store = createStore(browserHistory, client, window.reduxData);
Expand Down
1 change: 0 additions & 1 deletion src/containers/Home/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,4 +188,3 @@ const AsyncHome = asyncConnect([{
}])(Home);

export default connect(state => ({surahs: state.surahs.entities}))(AsyncHome);

16 changes: 8 additions & 8 deletions server.js → src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@ import raven from 'raven';
import errorhandler from 'errorhandler';

import config from 'config';
import expressConfig from 'server/config/express';
import expressConfig from '../server/config/express';

const pretty = new PrettyError();
const server = express();

expressConfig(server);

import routes from './src/routes';
import ApiClient from './src/helpers/ApiClient';
import createStore from './src/redux/create';
import debug from './src/helpers/debug';
import routes from './routes';
import ApiClient from './helpers/ApiClient';
import createStore from './redux/create';
import debug from './helpers/debug';

import Html from './src/helpers/Html';
import Html from './helpers/Html';

import { setUserAgent } from './src/redux/actions/audioplayer.js';
import { setOption } from './src/redux/actions/options.js';
import { setUserAgent } from './redux/actions/audioplayer.js';
import { setOption } from './redux/actions/options.js';

// Use varnish for the static routes, which will cache too
server.use(raven.middleware.express.requestHandler(config.sentryServer));
Expand Down
8 changes: 4 additions & 4 deletions webpack/dev.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var IsomorphicPlugin = require('webpack-isomorphic-tools/plugin');
var webpackIsomorphicToolsPlugin = new IsomorphicPlugin(require('./isomorphic-tools-configuration'));

module.exports = {
context: path.join(process.env.PWD, './'),
context: path.resolve(__dirname, '..'),
resolve: {
extensions: ['', '.js'],
modules: [
Expand All @@ -16,14 +16,14 @@ module.exports = {
]
},
entry: [
'webpack-dev-server/client?http://localhost:8001',
'webpack-hot-middleware/client?path=http://localhost:8001/__webpack_hmr',
'webpack/hot/only-dev-server',
'bootstrap-sass!./bootstrap.config.js',
'./client.js'
'./src/client.js'
],
output: {
path: path.resolve('./build'),
publicPath: '/public/',
publicPath: 'http://localhost:8001/public/',
filename: 'main.js'
},
module: {
Expand Down
5 changes: 4 additions & 1 deletion webpack/prod.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = {
sourceMapFilename: '[name]-[chunkhash].map.js'

},
context: path.resolve(__dirname, '../src'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change ../src to ..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 30 - change ./client.js to ./src/client.js

devtool: 'cheap-source-map',
debug: false,
target: 'web',
Expand Down Expand Up @@ -52,7 +53,9 @@ module.exports = {
'transform-runtime',
'add-module-exports',
'transform-decorators-legacy',
'transform-react-display-name'
'transform-react-display-name',
"transform-react-inline-elements",
"transform-react-constant-elements"
]
}
}
Expand Down
33 changes: 33 additions & 0 deletions webpack/webpack-dev-server.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
var Express = require('express');
var webpack = require('webpack');

var config = require('../src/config');
var webpackConfig = require('./dev.config');
var compiler = webpack(webpackConfig);

var host = config.host || 'localhost';
var port = (Number(config.port) + 1) || 3001;
var serverOptions = {
contentBase: 'http://' + host + ':' + port,
quiet: true,
noInfo: true,
hot: true,
inline: true,
lazy: false,
publicPath: webpackConfig.output.publicPath,
headers: {'Access-Control-Allow-Origin': '*'},
stats: {colors: true}
};

var app = new Express();

app.use(require('webpack-dev-middleware')(compiler, serverOptions));
app.use(require('webpack-hot-middleware')(compiler));

app.listen(port, function onAppListening(err) {
if (err) {
console.error(err);
} else {
console.info('==> 🚧 Webpack development server listening on port %s', port);
}
});