This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Remove supported check for audio #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had to check whether or not audio was of a supported format, since most of our audio files were ogg only (which wouldn't work on Safari and other browsers). Since we are now using mp3s for everything, we no longer need these checks.
Contributor
Author
|
Deployed to: http://staging.quran.com:32808 |
Contributor
Author
|
rebuild |
Contributor
Author
|
Deployed to: http://staging.quran.com:32809 |
Contributor
Author
|
this is good to merge once @mmahalwy approves - the "failing check" is the previous build which messed up because i had a typo in the jenkins config. |
Contributor
|
ty! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had to check whether or not audio was of a supported
format, since most of our audio files were ogg only (which wouldn't work
on Safari and other browsers). Since we are now using mp3s for
everything, we no longer need these checks.