Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

Conversation

@mmahalwy
Copy link
Contributor

I have observed too many times where users click a surah and expect something to happen. And something does after all the data is resolved and a transition happens. That's not a good experience for users.

  • Transitions on the client and shows loader until data is resolved
  • Fixes Search Page + transitions
  • Adds a new loader. The old one was great but the colors weren't even matching

@ahmedre
Copy link
Contributor

ahmedre commented Dec 20, 2016

Deployed to: http://staging.quran.com:33022

@naveed-ahmad
Copy link
Contributor

How about using pace ? It looks awesome! plus show actual progress of request

@thabti
Copy link
Contributor

thabti commented Dec 21, 2016

@mmahalwy Awesome.

@naveed-ahmad Lets try not to add too many dependencies, they're a pain to update. We are stuck on older version of react due to boot-strap.

@thabti thabti merged commit e205ae0 into master Dec 21, 2016
@mmahalwy
Copy link
Contributor Author

@naveed-ahmad pace looks pretty awesome! We can add it to another PR but this one was specific to getting the transitions working

@mmahalwy mmahalwy deleted the loading-transition branch December 21, 2016 11:24
@mmahalwy
Copy link
Contributor Author

Thanks @sabeurthabi!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants