Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed surah dropdown #793
  • Loading branch information
naveed-ahmad committed Jun 24, 2017
commit fb0da492749ef59275bc5daae4a23e9dfc92bd83
26 changes: 20 additions & 6 deletions src/components/SurahsDropdown/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,18 @@ const styles = require('./style.scss');

class SurahsDropdown extends Component {
shouldComponentUpdate(nextProps) {
return this.props.chapters !== nextProps.chapters;
return this.props.chapter.chapterNumber !== nextProps.chapter.chapterNumber;
}

renderList() {
const { chapters } = this.props;

return Object.values(chapters).map((chapter, index) => (
<LinkContainer to={`/${chapter.chapterNumber}`} activeClass="active" key={`chapter-${index}`}>
<LinkContainer
to={`/${chapter.chapterNumber}`}
activeClass="active"
key={`chapter-${index}`}
>
<MenuItem>
<div className="row">
<div className="col-xs-2 col-md-2">
Expand All @@ -27,9 +31,13 @@ class SurahsDropdown extends Component {
<div className="col-xs-7 col-md-7">
<span className="suran-name">{chapter.nameSimple}</span>
<br />
<span className="chapter-meaning">{chapter.translatedName.name}</span>
<span className="chapter-meaning">
{chapter.translatedName.name}
</span>
</div>
<div className={`col-xs-3 col-md-3 text-right ${styles.arabicName}`}>
<div
className={`col-xs-3 col-md-3 text-right ${styles.arabicName}`}
>
{chapter.nameArabic}
</div>
</div>
Expand All @@ -46,7 +54,13 @@ class SurahsDropdown extends Component {
link
className={styles.dropdown}
id="chapters-dropdown"
title={chapter.nameSimple || <LocaleFormattedMessage id="setting.chapters" defaultMessage="Surahs" />}
title={
chapter.nameSimple ||
<LocaleFormattedMessage
id="setting.chapters"
defaultMessage="Surahs"
/>
}
>
{this.renderList()}
</NavDropdown>
Expand All @@ -56,7 +70,7 @@ class SurahsDropdown extends Component {

SurahsDropdown.propTypes = {
chapters: customPropTypes.chapters.isRequired,
chapter: customPropTypes.chapters.isRequired,
chapter: customPropTypes.chapters.isRequired
};

export default SurahsDropdown;