This repository was archived by the owner on Jun 28, 2021. It is now read-only.
Use prop-types for PropTypes #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deployed to: http://staging.quran.com:32867 |
thabti
approved these changes
Nov 12, 2017
Contributor
|
Deployed to: http://staging.quran.com:32872 |
naveed-ahmad
approved these changes
Nov 13, 2017
Contributor
naveed-ahmad
left a comment
naveed-ahmad
left a comment
There was a problem hiding this comment.
PropTypes was removed from react for reducing the bundle size I suppose?
Contributor
Author
|
@naveed-ahmad good question. Not sure :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #878 but without the merge conflicts!
CC @hasibsahibzada