-
Notifications
You must be signed in to change notification settings - Fork 370
Upgrading to react-router 4 #893
Conversation
|
@sabeurthabti wanted to get your thoughts on how to handle the server-side stuff and code splitting. So far, this is a pain. I previously used |
|
Deployed to: http://staging.quran.com:32874 |
|
@mmahalwy I will be looking into this more tomorrow iA |
|
@sabeurthabti okay, this is working. I don't want to make this PR any larger and feel like a follow up PR can follow to polish. I think this is a good place to stop |
|
Tbh I have not done much server-rendering recently, so I wouldn't have had much input. LGTMI! |
|
rebuild |
|
@ahmedre I think jenkins died again :I |
|
rebuild |
|
thanks for the heads up - should be good now |
|
Deployed to: http://staging.quran.com:32875 |
Title of change
Upgrading to react-router 4
Checklist
yarnScreenshot
insert screenshot if needed