Skip to content
This repository was archived by the owner on Jun 28, 2021. It is now read-only.

Conversation

@mmahalwy
Copy link
Contributor

@mmahalwy mmahalwy commented Dec 4, 2017

Title of change

Moving the fonts setup to be in javascript and bootstrapped in the html file

Checklist

  • Unit tests written
  • Manually tested
  • New dependencies were added with yarn
  • Prettier & ESLint were run

Screenshot

@ahmedre
Copy link
Contributor

ahmedre commented Dec 4, 2017

Deployed to: http://staging.quran.com:32886

@hammady
Copy link

hammady commented Dec 4, 2017

Isn't FONTS_URL the same as ASSET_HOST in this commit?
Should we use the latter which is more generic?
Also as for the // to auto-select the url scheme, is it compatible with the change in src/config.js in the above commit, or should we remove it in this file?

@naveed-ahmad
Copy link
Contributor

Agree with @hammady we can use ASSET_HOST for serving all static assets( fonts, css, js ) but this isn't blocking change. We'll come back to this once cloudflare configuration are finished.

@naveed-ahmad naveed-ahmad merged commit b72c690 into master Dec 5, 2017
@naveed-ahmad naveed-ahmad deleted the fonts-in-html branch December 5, 2017 00:28
@mmahalwy
Copy link
Contributor Author

mmahalwy commented Dec 5, 2017

@hammady they are not the same unfortunately. One hosts all the fonts and the other all the assets

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants