Improve set_attrs() #113
Merged
Improve set_attrs() #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
May 1, 2017
- Takes uncopyable objects - set_attrs() is restricted to copyable objects
Doesn't seem as readable as explicitly calling set_attrs()
Since we now have better ways of creating empty vectors (e.g. dbl(), chr(), etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_attrs()now fails with uncopyable objectsmut_attrs()can be used to explicitly change attributes with side effectsNULL, zap attributesAlso,
_len()and_along()ctors don't pass...toset_attrs()anymore. It doesn't seem as readable as an explicit call toset_attrs().