Skip to content

Fix partial matching #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hadley merged 1 commit into from
Jun 28, 2018
Merged

Fix partial matching #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/testthat/test-parse.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test_that("Inline comments just before the closing brace are allowed", {

#' @seealso somewhere
}")[[1]]
expect_equal(get_tag(out, "seealso")$value, "somewhere")
expect_equal(get_tag(out, "seealso")$values, "somewhere")
})

test_that("Inline comments do not extend past the closing brace", {
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-rd-alias.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ test_that("refclass with assignment gets both aliases", {
B3 <- setRefClass('B3')
")[[1]]

expect_equal(get_tag(out, "alias")$value, c("B3-class", "B3"))
expect_equal(get_tag(out, "alias")$values, c("B3-class", "B3"))
})


Expand All @@ -74,5 +74,5 @@ test_that("refclass gets -class alias", {
setRefClass('B2')
")[[1]]

expect_equal(get_tag(out, "alias")$value, "B2-class")
expect_equal(get_tag(out, "alias")$values, "B2-class")
})
4 changes: 2 additions & 2 deletions tests/testthat/test-reexport.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ test_that("exporting a call to :: produces re-exports documentation", {
)

expect_equal(
out$get_field("title")$value,
out$get_field("title")$values,
"Objects exported from other packages"
)

expect_equal(out$get_field("keyword")$value, "internal")
expect_equal(out$get_field("keyword")$values, "internal")
})

test_that("multiple re-exports are combined", {
Expand Down