Skip to content

Conversation

@nteetor
Copy link
Member

@nteetor nteetor commented May 16, 2018

This problem was first raised in #699.

  • My approach is based on that used for inline code
  • I added one new test for code blocks and percent signs
  • I updated the existing code blocks test to account for the escaped percent signs

@hadley
Copy link
Member

hadley commented Jun 28, 2018

Looks great!

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@nteetor
Copy link
Member Author

nteetor commented Jun 28, 2018

Sure thing

@hadley
Copy link
Member

hadley commented Jun 28, 2018

@nteetor
Copy link
Member Author

nteetor commented Jun 28, 2018

Sorry, didn't catch up to master. You're all set on editing.

@hadley hadley merged commit de9e1c9 into r-lib:master Jun 28, 2018
@hadley
Copy link
Member

hadley commented Jun 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants