Exposes the streams property on server #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriacidre
approved these changes
Jan 15, 2018
Contributor
adriacidre
left a comment
adriacidre
left a comment
There was a problem hiding this comment.
LGTM, Thank you @gczn :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use-case which required that I had access to a list of streams being stored by the server.
Without exposing the steams property I'd have to independently store the steams myself (when I create them) which seemed a bit wasteful considering the slice already exists within the server struct.
I thought I'd pull request in-case anyone else wanted this, if this isn't something you'd like within the repository feel free to close my request.
I also don't mind creating a new method 'Servers()' which returns the slice in-case you want to keep the internal property private.