Skip to content

Reset the backoff time on successful connection #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reset the backoff time on successful connection #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ func (c *Client) SubscribeWithContext(ctx context.Context, stream string, handle
}
defer resp.Body.Close()

// Successful connection: reset the backoff time.
Copy link
Author

@pjcdawkins pjcdawkins Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little problematic as reconnection may also be invoked after a read error (not just after a request error), and here at the point of reading the response, the backoff will have been reset.

if c.ReconnectStrategy != nil {
c.ReconnectStrategy.Reset()
}

reader := NewEventStreamReader(resp.Body, c.maxBufferSize)
eventChan, errorChan := c.startReadLoop(reader)

Expand Down