Adds AutoReplay option to Stream #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the event log when a new subscriber is registered.
ernestbot
approved these changes
Jan 16, 2018
adriacidre
approved these changes
Jan 16, 2018
Contributor
|
LGTM ty @gczn :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a boolean flag to the Stream struct to allow enabling/disabling of replaying the eventlog to newly added subscribers.
Ensures backward-compatibility of functionality by defaulting the AutoReplay flag to true, which would emulate past behaviour.
Also added tests for when AutoReplay is both enabled and disabled.
Let us know if there's anything to be improved as part of this PR.