Update HTTPHandler to send events with new-line seperation #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team and I ran into an issue with subscribing to the HTTPHandler from a web client. It seems like the existing format for the event doesn't match the W3 recommendation.
W3 specifies that there should be a an empty new-line character between events.
For example:
Currently the HTTPHandler doesn't new-line separate.
For example:
The existing client in this library doesn't care about this distinction, but a web browser such as Chrome or Safari or a JS client can't parse the events. Adding a new-line fixes this.
Making this change doesn't effect the current client because it defaults to no behavior.