Skip to content

Conversation

@joshfix
Copy link
Contributor

@joshfix joshfix commented Aug 19, 2019

Related Issue(s): #35

Proposed Changes:

  1. Add documentation to the item spec in support of z-axis for geometry and bbox values.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

@joshfix joshfix added this to the 0.8.0 milestone Aug 19, 2019
@m-mohr
Copy link
Collaborator

m-mohr commented Aug 20, 2019

@joshfix I think there are potentially more places, which need an update:

  • api-spec.md, line 62 is about bbox and is missing the z-axis ("[west, south, east, north]")
  • To align between collection and item, I'd suggest to also update the collection-spec.md around line 67 (height vs. elevation).

Should a CHANGELOG entry be added? Not because it's really a change, but to make implementers aware of that they may have missed implementing z-axis support?

Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cholmes cholmes merged commit a35e106 into radiantearth:dev Aug 20, 2019
@hgs-msmith hgs-msmith mentioned this pull request Aug 20, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants