Skip to content

Conversation

@anayeaye
Copy link
Contributor

Related PR(s): #567 (closed because the branch based on master and a fairly old fork)
Addresses issue raised in STAC/Lobby

The README here https://github.com/radiantearth/stac-spec/tree/dev/extensions, under the section “Prefixes”, makes it seem like extension prefixes (like eo) are for keys in the properties object of the Item (this is also how https://github.com/radiantearth/stac-spec/blob/dev/extensions/eo/examples/example-landsat8.json is set up). The examples in https://github.com/radiantearth/stac-spec/blob/dev/extensions/eo/README.md make it seem like they go direclty into the body of the Item object. Is this a misplacement in the latter? Is extension Item information explicitly supposed to go into the properties object of the Item?

Proposed Changes:

  1. Modifies examples in Assets Object section of EO extension README to place eo:bands inside of item properties and corrects a linked example JSON.
  2. Updates Prefixes section of extension README with eo:gsd in place of eo:resolution.
  3. Includes changes from @m-mohr in the closed PR that improved consistency between EO examples and corrected another prefix in the EO example table.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required. Documentation changes only.
  • API only: I have run npm run generate-all to update the generated OpenAPI files. Not API.

…dated landsat example link. Extensions MD changes: updated eo:gsd and eo:off_nadir prefixes and applied suggested formatting changes for consistency between EO asset examples.
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@m-mohr m-mohr added this to the 0.8.0-RC1 milestone Aug 22, 2019
@m-mohr m-mohr requested a review from cholmes August 22, 2019 09:05
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much contributing!

@cholmes cholmes merged commit b0cd0cc into radiantearth:dev Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants