Skip to content

Align asset description #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m-mohr merged 1 commit into from
Jan 7, 2020
Merged

Align asset description #708

m-mohr merged 1 commit into from
Jan 7, 2020

Conversation

@m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jan 7, 2020 •
edited
Loading

Related Issue(s): None

Proposed Changes:

  1. We forgot to allow Commonmark in the asset description. There's no good reason to not allow it when all other descriptions allow it.
  2. We forgot to add the asset description field in the API.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

@m-mohr m-mohr added this to the 0.9.0 milestone Jan 7, 2020
@m-mohr m-mohr force-pushed the commonmark-asset-description branch from 2c21bd3 to 324ce6b Compare January 7, 2020 17:02
@m-mohr m-mohr added bug minor a relatively small change to the spec ready for review labels Jan 7, 2020
@m-mohr m-mohr changed the title Added Commonmark to asset description Align asset description Jan 7, 2020
@m-mohr m-mohr force-pushed the commonmark-asset-description branch from 324ce6b to 9edada2 Compare January 7, 2020 17:13
@m-mohr m-mohr merged commit 460d9a1 into dev Jan 7, 2020
@m-mohr m-mohr deleted the commonmark-asset-description branch January 7, 2020 22:07
@cholmes cholmes mentioned this pull request Jan 22, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cholmes cholmes cholmes approved these changes

@matthewhanson matthewhanson matthewhanson approved these changes

Assignees

No one assigned

Labels

bug minor a relatively small change to the spec

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@m-mohr @cholmes @matthewhanson